Native: Enabled import validation for native files

[gziolo]

Description

Follow-up for #16969.

This PR enables ESLint validation for native code which detects missing dependencies declaration for all packages.

Testing

npm run lint-js

It currently reports 6 errors at the moment which uncover some code issues where packages probably shouldn't be used. See the list of all errors:

gziolo@Grzegorzs-MacBook-Pro gutenberg % npm run lint-js

> gutenberg@6.7.0 lint-js /Users/gziolo/PhpstormProjects/gutenberg
> wp-scripts lint-js


/Users/gziolo/PhpstormProjects/gutenberg/packages/components/src/mobile/html-text-input/index.native.js
  11:1  error  '@wordpress/blocks' should be listed in the project's dependencies. Run 'npm i -S @wordpress/blocks' to add it  import/no-extraneous-dependencies
  12:1  error  '@wordpress/data' should be listed in the project's dependencies. Run 'npm i -S @wordpress/data' to add it      import/no-extraneous-dependencies

/Users/gziolo/PhpstormProjects/gutenberg/packages/edit-post/src/index.native.js
  11:1  error  '@wordpress/format-library' should be listed in the project's dependencies. Run 'npm i -S @wordpress/format-library' to add it  import/no-extraneous-dependencies

/Users/gziolo/PhpstormProjects/gutenberg/packages/rich-text/src/component/index.native.js
  19:1  error  '@wordpress/blocks' should be listed in the project's dependencies. Run 'npm i -S @wordpress/blocks' to add it                import/no-extraneous-dependencies
  20:1  error  '@wordpress/html-entities' should be listed in the project's dependencies. Run 'npm i -S @wordpress/html-entities' to add it  import/no-extraneous-dependencies
  22:1  error  '@wordpress/url' should be listed in the project's dependencies. Run 'npm i -S @wordpress/url' to add it                      import/no-extraneous-dependencies

✖ 6 problems (6 errors, 0 warnings)

[koke]

When I run npm install I see this warning:

npm WARN react-native@0.60.0 requires a peer of react@16.8.6 but none is installed. You must install peer dependencies yourself.

I thought there was something wrong with how the dependencies are set up but updating react to 16.8.6 in @wordpress/element and the main package.json gets rid of the warning

[gziolo]

Next time, we upgrade react-native we should ensure it uses the correct version of react then :)

Yes, all you need it to update those dependencies to the more recent versions.

By the way, we are working on updating react to v16.9.0.

[gziolo]

A few notes:

• @wordpress/components shouldn't depend on @wordpress/data or @wordpress/blocks - the usage should be updated to avoid it
• @wordpress/format-library is imported inside @wordpress/edit-post - I'm wondering why it is handled differently than in the web version - it should be aligned
• in @wordpress/rich-text shouldn't depend on @wordpress/blocks, I see why @wordpress/html-entities could be used, but why does it need @wordpress/url?

[gziolo]

There is also this question of whether react-native should be inlined into @wordpress/element similar to what we did with react-dom. This way we wouldn't have to repeat imports for react-native in all the places and keep the version in sync.

[hypest]

By the way, we are working on updating react to v16.9.0.

We have wordpress-mobile/gutenberg-mobile#1450 in a good place at the moment (need to make sure the iOS build works fine too) which will bring the RN and React upgrades on board.

[gziolo]

I'm closing it for now. It should be revisited once the Gutenberg mobile project is moved into this repository.