-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link Format: collapse selection to end after insert #17126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
daniloercoli,
etoledom,
jorgefilipecosta and
SergioEstevao
as code owners
August 21, 2019 13:00
ellatrix
requested review from
ajitbohra,
gziolo,
nerrad,
ntwb and
talldan
as code owners
August 21, 2019 14:34
ellatrix
force-pushed
the
try/link-selection
branch
from
August 22, 2019 11:45
6a27d1f
to
2cb659d
Compare
ellatrix
added
the
Good First Review
A PR that's suitable for someone looking to contribute for the first time by reviewing code
label
Aug 22, 2019
WunderBart
approved these changes
Mar 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get it in. |
mkaz
force-pushed
the
try/link-selection
branch
from
April 13, 2020 23:34
2cb659d
to
bf532b6
Compare
Size Change: +23 B (0%) Total Size: 839 kB
ℹ️ View Unchanged
|
mkaz
approved these changes
Apr 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good. I rebased it against master.
mkaz
force-pushed
the
try/link-selection
branch
from
April 13, 2020 23:59
bf532b6
to
ef3bfa1
Compare
The inserting of links cahnges, so need to remove the click to apply, and add tab + enter.
mkaz
force-pushed
the
try/link-selection
branch
from
April 14, 2020 22:28
42f19c4
to
4a29c55
Compare
2 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Good First Review
A PR that's suitable for someone looking to contribute for the first time by reviewing code
[Package] Format library
/packages/format-library
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Very small code change and change in behaviour.
With change:
How has this been tested?
Insert a link.
Screenshots
Types of changes
Checklist: