Components: Add ImageSizeControl component #17148
Conversation
ryelle
requested review from
ajitbohra,
chrisvanpatten,
gziolo,
jorgefilipecosta,
Soean,
talldan and
youknowriad
as code owners
|
@jorgefilipecosta, is it something that would fit into “@wordpress/media-utils” package? I don’t think we want to add more components to the “@wordpress/components” package which aren’t general purpose. This one is highly coupled to the block editor so it would be great to find an alternative which will help to share components specific to blocks. We discussed during the weekly Core JS chat that we should rather seek ways to make packages smaller. @nerrad, did you discuss it further this week? I guess we can still find some components which are very coupled to blocks in “@wordpress/components”. |
No, but for reference there's this issue I created (#17079) and during one of the GB triages this surfaced as well (#16709). I also just became aware of (#13910) as well which may help deal with some of the issues in some environments. I agree I think there should be some effort towards evaluating what should go in |
@mtias and @youknowriad, where are we with creating guidelines what should be part of |
|
It could be more explicit, but the guidelines require that the component be general use. It doesn't explain about different packages or a separate one for the editor though. I like the idea of having better organization for the packages, and a separate package for the editor, maybe Aside: I know it's new, but from now on the contribution guidelines should be followed when adding a new component. |
|
@drw158 Are you asking me to make a change here? This isn't an entirely new interface, just component-ifying something that already exists, so the prototype/spec aspects of that process don't really apply here. Overall, I'm happy to move this component wherever you all think is best, I personally have no input on where it belongs as long as it can be reused outside of core-gutenberg 🙂 |
|
I wish we had an So to answer your question, no changes are requested from me, but it would be great if someone with the knowledge could make an |
|
What does this need to become mergeable? |
There was a problem hiding this comment.
@jorgefilipecosta, is it something that would fit into “@wordpress/media-utils” package? I don’t think we want to add more components to the “@wordpress/components” package which aren’t general purpose. This one is highly coupled to the block editor so it would be great to find an alternative which will help to share components specific to blocks.
I don't think media utils is a good fit for this component. Media utils contain media-related components/utils that are WordPress specific. Artifacts there need a WordPress instance with the wp global available (e.g: the component to abstract the wp media library, function to upload to the WordPress media library).
I think this seems like a pure component that does not depends on WordPress; it just contains select and input controls/buttons. It is a component that allows to input width and height and supports a set of predefined width, height options. So it seems a UI component like the others. If in the future, if we have an infrastructure that allows live preview components/samples having it in the components package would enable us to take advantage of this feature.
On the other side, I understand that although being a pure UI component, adding every pure UI in components may make the package too big.
Another good possibility is adding it to the block-editor components folder, it contains components useful for block developers and not necessarily generic components, e.g: media placeholder is there https://github.com/WordPress/gutenberg//blob/5ac0b123e61554032ce3387de28cccd5686fabea/packages/block-editor/src/components/media-placeholder/index.js, I guess this folder could be seen as the editor package @drw158 referred.
jorgefilipecosta
removed
the
Needs Decision
|
It seems we did not arrive at a consensus on the ideal place for the component. I guess as a way to move the PR forward we can move the components to the block-editor package and export the component with the __experimental prefix we have other components in a similar situation there. |
|
Sure, I can update the PR in the next day or so to make that change 👍 |
If this isn't passed through, we don't show the dropdown
ryelle
force-pushed
the
add/component-image-size-control
branch
from
e8a699c
to
fbb187c
Compare
|
@jorgefilipecosta I've updated the PR, so |
|
Great! Does someone else need to approve, or can this be merged? I don't have access to merge, myself. |
|
@ryelle I see you have a bunch of good PRs already merged, I added you to the repo, so you could use branches, approve and merge PRs. |
ImageSizeControl does not live in `@wordpress/components` but in `@wordpress/block-editor`. The `__experimental` prefix is also needed. See WordPress#17148#issuecomment-569528836
ImageSizeControl does not live in `@wordpress/components` but in `@wordpress/block-editor`. The `__experimental` prefix is also needed. See #17148#issuecomment-569528836
Pull out the image size controls from the image block into a standalone component. This also updates the Image block to use this new component. The new component allows for selecting the source image size (if provided), and then adjusting the size from there – so you can pick the thumbnail, which sets the image size as 150x150, and then you can change the dimensions from there. The image block fetches each image's data directly, so it sets the source image height & width based on the real image size.
The idea is that this now-shared component can be used by the latest posts block to control featured images (and any plugins that add images).
To test
There should be no functionality change here.