[RNMobile] BottomSheet controls #17569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
gziolo
added
the
Mobile App - i.e. Android or iOS
jbinda
force-pushed
the
rnmobile/bottomsheet-controls
branch
from
1e8640f to
5aafa7d
Compare
|
@etoledom I have open PR to review and target to |
etoledom
approved these changes
Oct 1, 2019
There was a problem hiding this comment.
Nice job @jbinda !
Tested TextControl, ToggleControl and SelectControl on both iOS and Android and they just work beautifully 🎉
Note: Added a comment on code to be fixed before merging, but overall looks great.
Regarding the failing test, it's a known issue that a test regarding autosave might fail. #17652 (comment)
|
I've re-triggered CI (a few times) now they are all passing 🎉 |
|
thanks ! shall we merge it ? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR is connected with #1365 in gutenberg-mobile.
Please also refer to:
Related gutenberg-mobile PR
merge this PR first [RNMobile] add RangeControl mobile implementation and [RNMobile] refactor InspectorControls
It presents ability to select all parents in cascade way (according to the way how selecting in groups works on web version)
How has this been tested?
Manual test on Android and iOS plus CI tests
Types of changes
Adds new layer on top of
BottomSheet.Cellsto use controls placed inBottomSheetin the same way asSidebarcontrols in web version.Checklist: