RichText: don't focus when updating store #17615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
daniloercoli,
etoledom,
jorgefilipecosta and
SergioEstevao
as code owners
ellatrix
added
[Package] Rich text
|
Unsurprisingly, a lot of e2e test failures as we rely on setting focus a lot for merging and splitting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #17505. When updating the store, RichText shouldn't set any selection. This does NOT fix the popover issue. :) Only fixes the issue when updating the store directly.
Let's see if e2e tests pass.
How has this been tested?
See steps to reproduce in #17505.
Screenshots
Types of changes
Checklist: