Components: Add stories for Icon and IconButton #17868
Conversation
This update adds some initial Storybook stories for the Icon and IconButton component. Most of the stories were derived from the component's README.md documentation. Additional stories were added to showcase prop variation (e.g. `Icon` size), as well as composition (e.g. `IconButton` grouping). In order to render certain UI for the stories, some simple stateless functional components were created in the `.stories.js` file.
ItsJonQ
requested review from
ajitbohra,
chrisvanpatten,
gziolo,
jorgefilipecosta,
talldan and
youknowriad
as code owners
ItsJonQ
changed the title
gziolo
added
[Package] Components
|
@epiqueras do we have a live deploy in netlify for these PRs? How can we get the URL? |
|
Aside: it was discussed some time ago that it might make sense to deprecate |
|
@gziolo Thanks for that context! In that case, should I remove the |
I guess it's fine to proceed. We will have to keep |
😅 |
|
@youknowriad The link is in the PR checks, You'll need to manually add I just updated the Netlify config to match the new order of build scripts though, so we'll need a new commit in this PR to trigger a new build. |
|
@epiqueras https://deploy-preview-17868--gutenberg-playground.netlify.com/design-system/components This doesn't seem to work? |
|
This update adds some initial Storybook stories for the Icon and IconButton
component.
Most of the stories were derived from the component's README.md documentation.
Additional stories were added to showcase prop variation (e.g.
Iconsize),as well as composition (e.g.
IconButtongrouping).In order to render certain UI for the stories, some simple stateless
functional components were created in the
.stories.jsfile.