Check that scrollViewRef is still available before trying to scroll #17899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koke
added
the
Mobile App - i.e. Android or iOS
1 task
koke
force-pushed
the
issue/fix-scrollViewRef-crash
branch
from
d323c9a to
72e795e
Compare
pinarol
approved these changes
Oct 11, 2019
There was a problem hiding this comment.
LGTM 🎉 Tested as described in wordpress-mobile/gutenberg-mobile#1438 (review)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was meant to fix wordpress-mobile/gutenberg-mobile#1390 although I can't reproduce the issue anymore.
In any case, it's a good safety check. Since this happens in a delayed fashion, there scrollView might not exist anymore by the time this runs, so it's better to check that it's still there before trying to scroll.
Checklist: