Block Merge: guard for undefined attribute definition #17937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ellatrix thanks for adding this check, it will make it a lot easier to detect this problem in the future.
|
SergioEstevao
approved these changes
Nov 4, 2019
There was a problem hiding this comment.
@ellatrix thanks for adding this check, it will make it a lot easier to detect this problem in the future.
talldan
approved these changes
Nov 6, 2019
| ); | ||
|
|
||
| if ( ! attributeDefinition ) { | ||
| if ( typeof attributeKey === 'number' ) { | ||
| window.console.error( |
There was a problem hiding this comment.
Again this is another minor comment (which I don't think is a blocker for the PR). This seems like a very specific error, and I wonder whether it could be more generic by catching anything where value is defined but the type isn't a string, and adding something like this as the error:
`RichText needs an identifier prop that is the block attribute key of the attribute it controls. Its type is expected to be a string, but was ${ typeof attributeKey }`
gziolo
added
[Type] Bug
Co-Authored-By: Daniel Richards <daniel.richards@automattic.com>
ellatrix
commented
Nov 6, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related: wordpress-mobile/WordPress-iOS#11950. Cc @SergioEstevao.
Currently, when a block implements a merge function, but doesn't set the
identifierprop forRichText, merging will error because selection cannot be restored. Instead, we should log an error and let the merge continue without restoring selection.How has this been tested?
Screenshots
Types of changes
Checklist: