Add AYS dialog when attempting to leave editor in dirty state #1816
Conversation
westonruter
commented
Jul 8, 2017
westonruter
commented
|
Closes #1234. |
editor/effects.js
Outdated
| type: 'TRASH_POST_SUCCESS', | ||
| } ); | ||
| }, | ||
| ( err ) => { |
There was a problem hiding this comment.
I think I was originally going to use it for checking the dirty state, but I went a different direction. I've split this out into #1857.
editor/index.js
Outdated
| @@ -82,6 +86,15 @@ export function createEditorInstance( id, post ) { | |||
|
|
|||
| preparePostState( store, post ); | |||
|
|
|||
| const warnDirtyBeforeUnload = ( event ) => { | |||
There was a problem hiding this comment.
I'm not sure if this makes more sense here or further down the tree in a component like the one we have for SavedState.
There was a problem hiding this comment.
Actually, I'm inclined to create a separate component for this, use lifecycle to add the listeners (willMount, willUnmount) and add it to Layout.
mtias
added
[Feature] Document Settings
westonruter
force-pushed
the
add/before-unload-warning
branch
from
63852a3
to
11dcf8b
Compare
|
Rebased. Former head 63852a3. |
| post_type: postType, | ||
| ids: postId, | ||
|
|
||
| // Delay redirect to ensure store has been updated with the successful trash. |
There was a problem hiding this comment.
One thing that might be nice to have with the effects is the next function provided to middlewares, so that we could perform effects before or after the original action has been applied.
