Components: Switch screen-reader-text to VisuallyHidden #18165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaz
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta,
talldan and
youknowriad
as code owners
This was referenced Oct 29, 2019
mkaz
changed the title
This was referenced Oct 29, 2019
There was a problem hiding this comment.
I tested and this seems to work great on the FontSizePicker in #18149. I left two notes but nothing I think is a big problem.
gziolo
reviewed
Oct 30, 2019
Co-Authored-By: Grzegorz (Greg) Ziółkowski <grzegorz@gziolo.pl>
mkaz
force-pushed
the
fix/18127-screen-reader-text
branch
from
410e6a8
to
dc14595
Compare
|
Travis raises some concerns in e2e tests related to taxonomies. I restarted them but they might be valid looking at the scope of the changes. It might be also related to some unrelated changes in WordPress core. |
|
@gziolo yeh, I can't see why those tests are failing. I tried rebasing to see if that was part of the issue but didn't help. |
|
@gziolo - it was a valid issue with the test. It had a check for I've gotten to used to restarting tests to get them to pass. 😆 |
gziolo
approved these changes
Nov 4, 2019
daniloercoli
added a commit
that referenced
this pull request
Nov 5, 2019
…rnmobile/gb-mobile-872-JSApplicationIllegalArgumentException-in-RCTAztecView * 'master' of https://github.com/WordPress/gutenberg: (56 commits) Update: Default gradients. (#18214) Fix: setting a preset color on pullquote default style makes the block invalid (#18194) Fix default featured image size (#15844) Fix postmeta radio regression. (#18183) Components: Switch screen-reader-text to VisuallyHidden (#18165) [rnmobile] Release 1.16.0 to master (#18261) Template Loader: Add theme block template resolution. (#18247) Add a README file for storybook directory (#18245) Add editor-gradient-presets to get_theme_support (#17841) Add "Image Title Attribute" as an editable attribute on the image block (#11070) enables horizontal movers in social blocks (#18234) [RNMobile] Add mobile Spacer component (#17896) Add experimental `ResponsiveBlockControl` component (#16790) Fix mover for floats. (#18230) Rename Component to WPComponent in docstring (#18226) Colors Selector: replace `Aa` text by SVG icon (#18222) Removed gif from README (#18200) makes the submenu items stacked vertically (#18221) Add block navigator to sidebar panel for nav block (#18202) Fix: consecutive updates may trigger a blocks reset (#18219) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the follow up PR from comment in #18127 it addresses changing the other spots in components that use
screen-reader-textto usingVisuallyHiddencomponent.The two spots changed are:
base-controlandform-text-tokenHow has this been tested?
I created a story in Storybook to be committed in separate PR and confirmed that using the component shows the label as intended,
Types of changes
In essence it changes
<span className="screen-reader-text"> ... </span>to<VisuallyHidden> ... </VisuallyHidden>The base-control change uses label, and had a bit more logic wrapped around it.
Checklist: