Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LinkControl component to utilitse dynamic settings for additional settings "drawer" #18285

Merged
merged 10 commits into from
Nov 6, 2019
+173 −17
Merged

Update LinkControl component to utilitse dynamic settings for additional settings "drawer" #18285

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ab84e3d
Adds basic coverage test for new tab setting
getdave Nov 5, 2019
268da19
Refactor ‘new-tab` to camelCase for consistency
getdave Nov 5, 2019
63214ff
Fix bug with null render if settings has a length and convert to array
getdave Nov 5, 2019
ba312a9
Updates to loop over supplied settings
getdave Nov 5, 2019
0458a32
Updates docs
getdave Nov 5, 2019
b40ce8b
Updates Nav Item Block to utilise new setting format
getdave Nov 6, 2019
d0b17d1
Updates spacing between individual setting controls
getdave Nov 6, 2019
de238a6
Update docs for settings
getdave Nov 6, 2019
c3e553f
Updates setting key/id to match attribute to simply and improve consi…
getdave Nov 6, 2019
b194fe1
Fix Nav Menu Block dynamic setting of attribute
getdave Nov 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/block-library/src/navigation-menu-item/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,7 @@ import { Fragment, useState, useEffect } from '@wordpress/element';
* @param {Function} setter Setter attribute function.
*/
const updateLinkSetting = ( setter ) => ( setting, value ) => {
if ( setting === 'newTab' ) {
setter( { opensInNewTab: value } );
}
setter( { opensInNewTab: value } );
getdave marked this conversation as resolved.
Show resolved Hide resolved
};

/**
Expand Down Expand Up @@ -219,7 +217,7 @@ function NavigationMenuItemEdit( {
} }
currentSettings={ [
{
id: 'newTab',
id: 'opensInNewTab',
title: __( 'Open in New Tab' ),
checked: opensInNewTab,
},
Expand Down