Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix watching e2e tests #18391

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Fix watching e2e tests #18391

merged 1 commit into from
Nov 8, 2019

Conversation

talldan
Copy link
Contributor

@talldan talldan commented Nov 8, 2019

Description

#18003 removed npm run test-e2e:local, but it was still being used by npm run test-e2e:watch, causing that script to fail. This change resolves that issue.

How has this been tested?

  1. Run tests npm run test-e2e:watch
  2. Expect watch task to start.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@talldan talldan added the [Type] Bug An existing feature does not function as intended label Nov 8, 2019
@talldan talldan self-assigned this Nov 8, 2019
@talldan talldan requested review from epiqueras and gziolo November 8, 2019 06:56
gziolo
gziolo approved these changes Nov 8, 2019
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that, sorry about the trouble and thanks for fixing. I'm glad you are using this feature in your workflow 💯

@gziolo gziolo added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Nov 8, 2019
@gziolo gziolo merged commit 3bed7e5 into master Nov 8, 2019
@gziolo gziolo deleted the fix/watching-e2e-tests branch November 8, 2019 07:46
@talldan
Copy link
Contributor Author

talldan commented Nov 11, 2019

@gziolo, you fix so many other things so no need for an apology!

Thanks for reviewing and merging ❤️

@youknowriad youknowriad added this to the Gutenberg 6.9 milestone Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@epiqueras epiqueras Awaiting requested review from epiqueras

Assignees

@talldan talldan

Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 6.9
Development

Successfully merging this pull request may close these issues.
3 participants
@talldan @gziolo @youknowriad