Link Control: fix setting rich-text placeholder #18488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retrofox
added
[Feature] List View
retrofox
requested review from
ellatrix,
talldan and
youknowriad
as code owners
retrofox
requested review from
ajitbohra,
jorgefilipecosta and
Soean
as code owners
After this change 8e13521 is mandatory to remove the `>` from the CSS rule to make it work, since it is not a straightforward child of the CSS class anymore.
retrofox
force-pushed
the
update/link-popover-fix-visual-bug
branch
from
80a9039
to
ecad058
Compare
retrofox
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to make stronger the CSS rule which overrides the styles for the<URLInput >block properly. It's doable prefixing the rule with the.components-popoverCSS class.After this change 8e13521 is mandatory to remove the
>from the CSS rule to make it work, since it is not a straightforward child of the CSS class anymore.How has this been tested?
Testing with a navigation menu, confirm that the link popover is broken when the item doesn't have defined a link:
Applying this change, the popover should look good again:
Screenshots
Types of changes
Checklist: