Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Title: Access the new API endpoint for editing the site title #18970

Closed

Conversation

scruffian
Copy link
Contributor

Description

This implement the new REST API endpoints added here:
https://core.trac.wordpress.org/ticket/48885

How has this been tested?

Create a new post and add the site title block. You should be able to view and edit the site title.
Now log in as an "Editor". You should be able to view the site title, but not edit it.

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@earnjam
Copy link
Contributor

earnjam commented Mar 21, 2020

@scruffian Based on what I read in the Trac ticket, this approach is outdated based on feedback from the REST API team, correct? I think we had decided not to add a new /settings/public route.

I see you have a couple of other PRs related to this open in #18760 and #19967. Should we close this one in favor of those two?

Also should add a note based on the changes in this PR, if we are going to implement something that relies on REST API changes in core, we'd also want to implement those changes in Gutenberg so that the plugin is not dependent on WP core trunk.

@scruffian
Copy link
Contributor Author

Yeah lets close this since we decided to do it a different way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants