E2E Tests: Validate embed rendering before proceeding to next #19042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
[Type] Automated Testing
aduth
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
ellatrix
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19033
This pull request seeks to improve stability of the embedding end-to-end test suite. See #19033 for complete debugging details.
The changes here operate on the assumption that there is a race condition between embed resizing and the behavior of Puppeteer's
page.clickto bring the block appender into view between adding embeds.The goal of these changes is to change from:
Before: Add all blocks, then validate the results.
After: Validate the result of an embed insertion before proceeding to add the next.
The idea with this is that, by performing the validation using
waitForSelector, we can have a higher confidence that the embed preview is rendered in its final state, and won't be subject to further resizing.Testing Instructions:
Build should pass.
Ensure end-to-end tests pass: