Popover: reposition on click #19268
Merged
Popover: reposition on click #19268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
ellatrix
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta,
talldan and
youknowriad
as code owners
|
I think this PR may have caused #19977. I tried checking out the history of the popover, and it started working just before this PR. It's interesting to note that no-one noticed 😅 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when opening or closing the sidebar for example, popovers only reposition after a delay. I've added a click listener to also refresh the popover positions because it might have changed the layout.
How has this been tested?
Create an image block. Focus the caption field so an inline toolbar pops up. Now open and close the sidebar a few times. Notice that there is a delay in repositioning the popover, which is now smooth with this PR.
Screenshots
Types of changes
Checklist: