Reusable blocks: Add to Block Manager #19400
Conversation
gziolo
added
the
[Feature] Synced Patterns
|
The "Manage All Reusable Blocks" link has been removed from the Options popover.
The Reusable blocks category is now added to the Block Manager along with the "Edit blocks" link.
|
| @@ -75,6 +75,10 @@ | |||
| font-size: 0.9rem; | |||
| font-weight: 600; | |||
| } | |||
|
|
|||
| > a { | |||
| float: right; //Aligning link to the right of category heading. | |||
There was a problem hiding this comment.
It looks like using float changes only the visual appearance but not the tabbing order:
We need to find a different approach here.
There was a problem hiding this comment.
Yeah, I was wondering about that. float:right works easier this way, but tab order is off now. I'll fix this.
|
I've added
|
gziolo
force-pushed
the
update/reusable-blocks-manager
branch
from
faa3d6f to
981a4e2
Compare
packages/edit-post/src/components/manage-blocks-modal/category.js
Outdated
Show resolved
Hide resolved
gziolo
force-pushed
the
update/reusable-blocks-manager
branch
from
2598057 to
ec54604
Compare
|
@mapk, I'm nearly there. I still need to apply filtering for Reusable Blocks in the inserter. Block Manager seems to work as intended. I didn't test it very extensively, I will resume tomorrow.
|
|
I must admit that I didn't anticipate the amount of refactoring necessary to apply this simple change. First, we had to ensure that reusable blocks are exposed in the Block Manager. I wrongly assumed that they are there. Now, it’s tricky to filter out hidden reusable blocks from the inserter, because the existing logic depends on the list of allowed blocks that can be exposed from the server and then merged with those hidden in the Block Manager by users. It’s also very likely that we will want to make it possible to hide newly introduced block variations from the inserter as well. Ideally, we tackle reusable blocks in a way that makes it easy to follow-up with block variations. I prefer to not rush with this feature and include it first in the regular flow where it lands in the Gutenberg plugin first and is properly tested. |
|
How's this one going, @gziolo ? Is there anything I can help with? |
I need to revisit it, there is some challenge in resolving how settings are propagated between internal packages. I hope to get back to it later this month. |
|
@gziolo any updates on this one? |
|
@mapk I was busy with other tasks, it's still on my todo list 👍 |
|
I'm starting extended leave soon (3 months) and I won't be able to finish this task until I'm back. If anyone wants to take over this task, feel free to do so 🥇 |
|
Seems I can't test this PR: there's no "Reusable blocks" section in the modal for me. I guess this PR is a bit behind. |
|
@afercia I'm afraid you are right. Let's close it and start fresh. |
Description
Closes #13390.
WIP
How has this been tested?
Screenshots
Types of changes
Checklist: