Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nav Block - show recent pages as default suggestions when creating Nav Links #19458

Merged
merged 29 commits into from
Jan 15, 2020
Merged

Nav Block - show recent pages as default suggestions when creating Nav Links #19458

merged 29 commits into from
Jan 15, 2020

Commits on Jan 15, 2020

  1. Adds ability to manual trigger search data fetch

    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    4d693f3 View commit details
    Browse the repository at this point in the history

  2. Update to prop to experimental and rename to initialSuggestions

    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    a124c1b View commit details
    Browse the repository at this point in the history

  3. Query for and display 5 most recently modified Pages

    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    a94b1c3 View commit details
    Browse the repository at this point in the history

  4. Update initial suggestions to be display whenever the input is empty … 

    …and there are no current suggestions

This is needed to ensure that the async fulfillment of the initialSuggestions prop causes the component to re-render and display the initial suggestions. Without this the initial suggestions would only be available if the prop is fufilled on the initial component mount.
    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    56b8ff8 View commit details
    Browse the repository at this point in the history

  5. Fix to ensure initial suggestions are shown when pages request fulfills 

    Addresses issues noted in #19458 (comment)
    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    a4e205c View commit details
    Browse the repository at this point in the history

  6. Updates to display 3 most recently modified pages instead of 5 

    Addresses #19458 (comment)
    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    5384967 View commit details
    Browse the repository at this point in the history

  7. Fix to allow keyboard arrow to move focus into suggestions when present 

    Previously it was not possible to use the down arrow key to move the focus into the search suggestions when initialSuggestions were displayed. This was due to requirement for there to be a value in the `input` which is now no longer valid now that initial suggestions can be displayed.

Note that removing the derived setting of selectedSuggestion state is valid as selectedSuggestions are always reset on each new data fetch anyway.

Resolves issue noted in #19458 (comment)
    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    eeacd74 View commit details
    Browse the repository at this point in the history

  8. Fix bug whereby not providing initialSuggestions to LinkControl disab… 

    …led the ability to search at all

Test failures led to uncovering of a bug whereby the URLInput component’s `updateSuggestions` method would exit early it initialSuggestions wasn’t provided. As initialSuggestions is an optional prop this means that all fetching of search suggestions was disabled if the initialSuggestions wasn’t provided.

Fixed this bug and all tests by improving the conditionals.
    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    2bf0d68 View commit details
    Browse the repository at this point in the history

  9. Adds tests to cover displaying initial suggestions

    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    3923795 View commit details
    Browse the repository at this point in the history

  10. Removes redundant const comment

    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    8b23050 View commit details
    Browse the repository at this point in the history

  11. Test fix to e2e tests

    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    7d34ed5 View commit details
    Browse the repository at this point in the history

  12. Try looser mock request matching to fix e2e test failures

    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    c37497e View commit details
    Browse the repository at this point in the history

  13. Try fix Travis e2e test failure by clearing request mocks

    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    cf55b73 View commit details
    Browse the repository at this point in the history

  14. Fix not awaiting mock setup

    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    573972f View commit details
    Browse the repository at this point in the history

  15. Fix inadvertant revert of e2e test fix

    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    ee6c5b8 View commit details
    Browse the repository at this point in the history

  16. Refactor to remove seperate initialSuggestions query 

    As per the GH thread below, this refactors the code to avoid the need to introduce a new fetch API around `__experimentalInitialSuggestions`. Now instead we simply reuse the existing fetchSuggestions handler to get the initial results. The only different being we introduce an arguments object to queries to restrict the number of results displayed for initial Suggestions.

See #19458 (comment)
    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    c96409c View commit details
    Browse the repository at this point in the history

  17. Refactor to use empty value as condition for initialSuggestions request 

    Addresses #19458 (comment)
    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    5eef3dd View commit details
    Browse the repository at this point in the history

  18. Fix “suggestions” typo

    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    f500fe4 View commit details
    Browse the repository at this point in the history

  19. Update to reuse existing edit constant

    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    0208bc6 View commit details
    Browse the repository at this point in the history

  20. Fix initial suggestions showing when input has value

    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    2244e33 View commit details
    Browse the repository at this point in the history

  21. Fix potential infinite render using flag to conditionalise updating s… 

    …uggestions on update or mount
    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    a31f651 View commit details
    Browse the repository at this point in the history

  22. Add test to cover inifinite re-render loop.

    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    3b8b6ea View commit details
    Browse the repository at this point in the history

  23. Fixes typo in WordPress ORG link in e2e tests

    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    1ca624b View commit details
    Browse the repository at this point in the history

  24. Fix e2e test failure due to console warning in LinkControl 

    This is a temp fix and I’ve raised an Issue to solve the core issue which will then make this fix redundant.

#19634
    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    b6d6c26 View commit details
    Browse the repository at this point in the history

  25. Revise snapshots

    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    abe616c View commit details
    Browse the repository at this point in the history

  26. Restore missing fetchSearchSuggestions prop following rebase

    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    259938a View commit details
    Browse the repository at this point in the history

  27. Fix lint indentation error

    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    385d04f View commit details
    Browse the repository at this point in the history

  28. Rename prop

    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    5dc5716 View commit details
    Browse the repository at this point in the history

  29. Fix test broken due to prop rename

    @getdave
    getdave committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    8c648a3 View commit details
    Browse the repository at this point in the history