Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try Building a Template Block #1970

Closed
wants to merge 5 commits into from
Closed

Try Building a Template Block #1970

wants to merge 5 commits into from

Commits on Jul 21, 2017

  1. Add a sample template block

    @nb
    nb committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    5417e6a View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2017

  1. Extract the transformation into its own function 

    Currently named `transformComponentToText`, open to other names.

Also may open the door for other transforms like this.
    @nb
    nb committed Jul 25, 2017
    Configuration menu
    Copy the full SHA
    b6d204a View commit details
    Browse the repository at this point in the history

  2. Extra AttributeInput component 

    Its value is always in sync with an attribute.
    @nb
    nb committed Jul 25, 2017
    Configuration menu
    Copy the full SHA
    6e30b3d View commit details
    Browse the repository at this point in the history

  3. Switch to span from p for the main tag 

    Make it inline, so that we can safely put in a text block later.
    @nb
    nb committed Jul 25, 2017
    Configuration menu
    Copy the full SHA
    763f741 View commit details
    Browse the repository at this point in the history

  4. Switch to the extracted functionality 

    `AttributeInput` and `transformComponentToText`
    @nb
    nb committed Jul 25, 2017
    Configuration menu
    Copy the full SHA
    dd7af5b View commit details
    Browse the repository at this point in the history