Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing Flow: fix list selection (2) #19724

Closed
wants to merge 2 commits into from
Closed

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Jan 17, 2020

Description

Alternative to #19721, but again here, I fail to write a passing test. It does work fine when testing manually, just like #19721.

I made an error making the e2e test and now it works, but there are other tests that fail.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@ellatrix ellatrix added [Type] Bug An existing feature does not function as intended [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... labels Jan 17, 2020
@ellatrix ellatrix requested a review from aduth January 17, 2020 15:03
@ellatrix ellatrix changed the title Writing Flow: fix list selection Writing Flow: fix list selection (2) Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant