Block Editor: LinkControl: Align documentation with current behavior #19736
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to address a few consistency issues with the LinkControl documentation:
className
propvalue
is not requiredonChange
will always receive an item, nevernull
onChange
example referenced the wrong (old) proponLinkChange
, and the example used an impossible scenario that the changeditem
could be falsey.Separately, I would like to improve documentation and types concerning what a value actually is. These are intended as an incremental step in that direction.
Testing Instructions:
The only changes impact documentation and tests. There is no expected impact on the behavior of the application runtime.
Ensure unit tests pass: