Block Editor: Generate consistent suggestion object by URL #19827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #19816
cc @getdave
Work in Progress: Sharing this pull request early to explore ideas and possible solutions. Not all of it makes sense, and much of it could be paired down to smaller, focused pull requests.
The general goals here include:
getSuggestionByURL
helper is used in both places.url
property, it would inherit all other properties from the previously-selected value (title, etc), which would probably not be expected.'url'
type. This is toward a goal of treating these as distinct from post-based suggestions on the basis oftype
, where all post or page suggestions are grouped under the'post'
type distinction. This is also consistent with existing logic for considering these values as "URL"s.subtype
could at least be beneficial in being consistent with the interface of a "suggestion" (as in where the subtype of a'post'
suggestion is the post type).