Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Post: Hide block drag handle in top toolbar. #20013

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

epiqueras
Copy link
Contributor

Closes #19602

Description

This PR adds an option to the block toolbar for disabling the block drag handle and uses it to hide it in the top toolbar mode. Starting a block drag from up there doesn't really make for a nice experience.

How has this been tested?

It was verified that the top toolbar no longer has a block drag handle.

Screenshots

Before

Screen Shot 2020-02-03 at 2 18 09 PM

After

Screen Shot 2020-02-03 at 2 21 34 PM

Types of Changes

Bug Fix: The top toolbar no longer has a drag handle.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@epiqueras epiqueras added [Type] Bug An existing feature does not function as intended General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. labels Feb 3, 2020
@epiqueras epiqueras self-assigned this Feb 3, 2020
Copy link
Contributor

@mapk mapk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested. Looks and works correctly. Thanks for removing this from the Top Toolbar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Top Toolbar" mode now has drag handle (broken) and arrows, should it?
2 participants