Social Links: Consistently rebrand as Social Icons #20101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsf
added
the
[Block] Social
mcsf
requested review from
ajitbohra,
mkaz,
nerrad,
ntwb and
talldan
as code owners
gziolo
reviewed
Feb 7, 2020
gziolo
approved these changes
Feb 7, 2020
Since #19887, `core/social-link` was already titled "Social Icon". This PR does the same to parent `core/social-links`.
Co-Authored-By: Grzegorz (Greg) Ziółkowski <grzegorz@gziolo.pl>
mcsf
force-pushed
the
update/social-links-rename-to-icons
branch
from
c5aa21c
to
e472ad3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #19887,
core/social-linkwas already titled "Social Icon". This PR does the same to parentcore/social-links.Note: This is not the same as renaming the block's
name, something which would affect how content is saved. Internally renaming the block isn't off the table, but is a greater commitment that we don't need to make right away.How has this been tested?
Screenshots
Types of changes
Checklist: