Stabilize and document the angle picker component; Rename to AnglePickerControl; #20118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Developer Documentation
jorgefilipecosta
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
18 tasks
jorgefilipecosta
force-pushed
the
update/stabilize-and-document-the-angle-picker-component
branch
from
cf0cd76 to
4c117bb
Compare
|
Hi @chrisvanpatten, I renamed the component to AnglePickerControl. |
jorgefilipecosta
changed the title
chrisvanpatten
approved these changes
Feb 9, 2020
youknowriad
reviewed
Feb 10, 2020
jorgefilipecosta
force-pushed
the
update/stabilize-and-document-the-angle-picker-component
branch
3 times, most recently
from
b0f06c9 to
d48680d
Compare
jorgefilipecosta
force-pushed
the
update/stabilize-and-document-the-angle-picker-component
branch
from
d48680d to
b2132a7
Compare
jorgefilipecosta
deleted the
update/stabilize-and-document-the-angle-picker-component
branch
aduth
reviewed
Feb 12, 2020
| "resolved": "https://registry.npmjs.org/node-pre-gyp/-/node-pre-gyp-0.12.0.tgz", | ||
| "resolved": false, |
There was a problem hiding this comment.
I don't see why these changes would be expected here?
When I run npm install on master using the recommended (latest) version of NPM (6.13.7), I see this being flipped back to the value it was previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR stabilizes and documents the angle picker component.
How has this been tested?
I verified in the browser console that the angle picker component was now exposed as wp.components.AnglePicker.