Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Starter Page Templates code for web #20137

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Conversation

koke
Copy link
Contributor

@koke koke commented Feb 10, 2020

Description

As part of the effort to clean up experimental APIs in 5.4 (#20116), this reverts the page template code from #18052 for the web. We are shipping the feature on mobile soon, but the web variant is still an initial prototype. There is an ongoing discussion in #17335 about how layouts might work on the web.

Types of changes

Removing an unfinished experiment.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@koke koke added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Feb 10, 2020
Copy link
Member

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this cleanup 🧹!

Tested this on both iOS, Android and local Gutenberg Web.

LGTM!

@koke koke merged commit 8b9f65d into master Feb 11, 2020
@koke koke deleted the remove/spt-experiment-from-web branch February 11, 2020 14:34
@github-actions github-actions bot added this to the Gutenberg 7.6 milestone Feb 11, 2020
@ellatrix ellatrix mentioned this pull request Jun 16, 2020
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants