Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core Data: Remove unused __experimentalUseEntitySaving hook. #20148

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Core Data: Remove unused __experimentalUseEntitySaving hook. #20148

merged 1 commit into from
Feb 10, 2020

Conversation

epiqueras
Copy link
Contributor

Follows #20116.

@epiqueras epiqueras added the [Package] Core data /packages/core-data label Feb 10, 2020
@epiqueras epiqueras added this to the Gutenberg 7.5 milestone Feb 10, 2020
@epiqueras epiqueras self-assigned this Feb 10, 2020
aduth
aduth approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no context here to know for what reason this existed, or when it was added or removed. That said, as best I can determine, it does appear to be dead code and safe for removal.

@epiqueras epiqueras merged commit ab5405d into master Feb 10, 2020
@epiqueras epiqueras deleted the remove/unused-experimental-core-data-hook branch February 10, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth aduth approved these changes

@nerrad nerrad Awaiting requested review from nerrad

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@epiqueras epiqueras

Labels
[Package] Core data /packages/core-data
Projects
None yet
Milestone
Gutenberg 7.5
Development

Successfully merging this pull request may close these issues.
2 participants
@epiqueras @aduth