Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Bring release v1.22.0 to master #20155

Merged
merged 8 commits into from
Feb 11, 2020

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Feb 10, 2020

Description

This PR merges all the changes that landed on the v1.22.0 of the mobile block editor that hadn't been on master yet.

How has this been tested?

With the gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1877

Types of changes

The only new work not already on master is #20095 and was tested as part of the mobile release itself.

It also enables the Travis builds on the rnmobile/release* branches (041394d#diff-354f30a63fb0907d4ad57269548329e3R22).

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

Tug and others added 8 commits January 10, 2020 18:03
* styling fixes after navigation feature merge (#19455)

* Styling fixes to navigation feature

* Add netural styles for toolbar

* Fix condition for not registered component

* Display 'Unsupported' in breadcrumbs for missing components

* Refactor after CR

* Remove leftovers

* [FIX] rich text focus loop (#19240)

* check if onBlur event contains text that is different than value

* add check if there is a text in native event

* Prevent re-selection of RichText when native selection changes as a result of resigning focus

* Fix typo

* Check if isSelected only in onSelectionChangeFromAztec

Co-authored-by: Jorge Bernal <jbernal@gmail.com>

* [RNMobile] Correct displaying photo during upload (#19502)

* [RNMobile] Fix crash once adding Group (#19457)

* Add extra branch for travis to run tests onto

Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
Co-authored-by: Drapich Piotr <drapich.piotr@gmail.com>
Co-authored-by: Jorge Bernal <jbernal@gmail.com>
This fixes a crash originated on this PR:
#19536
`
* Fix blank image size labels on mobile

* Use name instead of label in default imageSizes
* Add flag for determining if running on Android

* Enable Dismiss button on PlainText. Enable show keyboard in Android on PlainText mount

* Enable Dismiss button on PlainText. Enable show keyboard in Android on PlainText mount
@hypest hypest added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Feb 10, 2020
@hypest hypest requested a review from marecar3 February 10, 2020 21:02
@hypest
Copy link
Contributor Author

hypest commented Feb 11, 2020

The changes in this PR have been tested during the release, and since CI is green I will self-merge (admin merge).

@hypest hypest merged commit 7dda20a into master Feb 11, 2020
@hypest hypest deleted the rnmobile/merge-1.22.0-to-master branch February 11, 2020 09:10
@github-actions github-actions bot added this to the Gutenberg 7.6 milestone Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants