Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing i18n in custom gradient picker #20184

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

pedro-mendonca
Copy link
Contributor

Fixes #20183

Description

Add missing i18n to Gradient type in the block "Buttons".

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.

@jorgefilipecosta jorgefilipecosta changed the title Fix missing i18n in "Buttons" block gradient types Fix missing i18n in custom gradient picker Feb 12, 2020
@jorgefilipecosta jorgefilipecosta added [Type] Bug An existing feature does not function as intended Internationalization (i18n) Issues or PRs related to internationalization efforts labels Feb 12, 2020
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @pedro-mendonca! Thank you for fixing this issue 👍

@jorgefilipecosta jorgefilipecosta merged commit 147d142 into WordPress:master Feb 12, 2020
@jorgefilipecosta jorgefilipecosta added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 12, 2020
@github-actions github-actions bot added this to the Gutenberg 7.6 milestone Feb 12, 2020
@pedro-mendonca
Copy link
Contributor Author

You're welcome, thanks for verifying 👍

@jorgefilipecosta jorgefilipecosta removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[i18n] Block "Buttons" strings missing i18n.
3 participants