RNMobile: Only fetch image data if image url is not a local file #20202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchowning
added
the
Mobile App - i.e. Android or iOS
Merged
2 tasks
mkevins
approved these changes
Feb 14, 2020
There was a problem hiding this comment.
I tested this on Pixel 3a (Android 10) via the steps described here: wordpress-mobile/WordPress-Android#11239 (comment) and this indeed addresses the "symptoms" exhibited within the Image block, and fixes wordpress-mobile/gutenberg-mobile#1853 as described.
I was also able to reproduce the issue noted here: wordpress-mobile/gutenberg-mobile#1896. A solution to that may require more investigation, and might be out of scope for this PR.
Nice work @mchowning 👍
| @@ -78,6 +78,8 @@ const getUrlForSlug = ( image, { sizeSlug } ) => { | |||
| return get( image, [ 'media_details', 'sizes', sizeSlug, 'source_url' ] ); | |||
| }; | |||
|
|
|||
| const isFileUrl = ( url ) => url && url.startsWith( 'file:' ); | |||
mchowning
deleted the
rnmobile/issue/1853_image-upload-preview-incorrect-on-id-conflict
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related gutenberg-mobile PR
Description
Addresses wordpress-mobile/gutenberg-mobile#1853 by not attempting to fetch an image that has a local file path url. This avoids accidentally fetching the wrong image when the local image id conflicts with a different remote id.
How has this been tested?
Checklist: