Fix: Inline image width pop-up 'wanders' down page #20232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
requested review from
daniloercoli,
ellatrix,
etoledom and
SergioEstevao
as code owners
jorgefilipecosta
added
[Package] Format library
youknowriad
reviewed
Feb 14, 2020
It may benefit from a refactor, but my plan was to cherry-pick this into the next WordPress beta so I avoided a major change to the component to avoid creating some unknown bug. |
youknowriad
approved these changes
Feb 17, 2020
jorgefilipecosta
force-pushed
the
fix/inline-image-width-pop-up-wanders-down-page
branch
from
08cb019
to
12aff9e
Compare
jorgefilipecosta
deleted the
fix/inline-image-width-pop-up-wanders-down-page
branch
jorgefilipecosta
added
the
Backport to WP 6.7 Beta/RC
jorgefilipecosta
added a commit
that referenced
this pull request
Feb 17, 2020
jorgefilipecosta
added a commit
that referenced
this pull request
Feb 17, 2020
jorgefilipecosta
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix: #19519
How has this been tested?
I added multiple inline images to a paragraph.
I selected an inline image and changed its width in the popover, I verified the popover did not move.
I changed the selected inline image, I verified the popover update its position to be close to the selected inline-image.