@wordpress/env: Use user with UID=33 to run WP CLI commands #20403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The www-data user in wordpress:cli has a different UID (82) to the www-data user in wordpress (33). Ensure we use the wordpress www-data user for CLI commands. See docker-library/wordpress#256 for more discussion.
noisysocks
added
[Type] Bug
epiqueras
approved these changes
Feb 24, 2020
|
Size Change: 0 B Total Size: 864 kB ℹ️ View Unchanged
|
|
It looks like there's a similar but unrelated issue with media uploads failing when |
noisysocks
deleted the
fix/wp-env-config-overrides-on-production-wordpress
branch
|
I wonder if this will help with the other permissions error @ockham mentioned |
|
Thanks! Confirming that this fixes the issue that (Noah and) I were running into -- so I can, once again, run ~/src/gutenberg$ npx wp-env start
✔ WordPress started. (in 958s 579ms)
~/src/gutenberg$ npx wp-env stop
✔ Stopped WordPress. (in 5s 506ms)
~/src/gutenberg$ npx wp-env start
✖ EACCES: permission denied, open '/home/me/wp-env/6ac6b03bd54e5e922f0d180f6d7ff25d/tests-WordPress/wp-config.php'
[Error: EACCES: permission denied, open '/home/me/wp-env/6ac6b03bd54e5e922f0d180f6d7ff25d/tests-WordPress/wp-config.php'] {
errno: -13,
code: 'EACCES',
syscall: 'open',
path: '/home/me/wp-env/6ac6b03bd54e5e922f0d180f6d7ff25d/tests-WordPress/wp-config.php'
} |
|
It's honestly a little bit funny that it doesn't work the second time. Very strange. :) |
jorgefilipecosta
added
the
Backport to WP 6.7 Beta/RC
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 2, 2020
The www-data user in wordpress:cli has a different UID (82) to the www-data user in wordpress (33). Ensure we use the wordpress www-data user for CLI commands. See docker-library/wordpress#256 for more discussion.
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 2, 2020
The www-data user in wordpress:cli has a different UID (82) to the www-data user in wordpress (33). Ensure we use the wordpress www-data user for CLI commands. See docker-library/wordpress#256 for more discussion.
jorgefilipecosta
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #20352. Fixes the issue described in #20180 (comment).
The
www-datauser inwordpress:clihas a different UID (82) to thewww-datauser inwordpress(33). This change ensures we use thewordpresswww-datauser for CLI commands.This only is an issue when
"core"in.wp-env.jsonis set tonull, because this means that we're using a volume mount instead of a bind mount. Files in a bind mount have the same permissions as they do on the host system.See docker-library/wordpress#256 for more discussion on this.
cc. @noahtallen @epiqueras