-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Editor: Typewriter: Skip entire component for IE #20485
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Bug
An existing feature does not function as intended
Browser Issues
Issues or PRs that are related to browser specific problems
[Feature] Writing Flow
Block selection, navigation, splitting, merging, deletion...
labels
Feb 26, 2020
Size Change: +2 B (0%) Total Size: 866 kB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Feb 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test but it seems logical.
Thanks for fixing this! |
aduth
added
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Feb 28, 2020
@jorgefilipecosta Just to note, when this is cherry-picked for 5.4 RC, the following Trac ticket can be flagged as fixed: |
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 2, 2020
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 2, 2020
jorgefilipecosta
removed
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Browser Issues
Issues or PRs that are related to browser specific problems
[Feature] Writing Flow
Block selection, navigation, splitting, merging, deletion...
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Trac#49516
Related: #16460
This pull request seeks to resolve an error that occurs in the Typewriter component when used in Internet Explorer. Notably, the Typewriter component was written to intentionally bypass itself in Internet Explorer:
gutenberg/packages/block-editor/src/components/typewriter/index.js
Lines 238 to 243 in d026d5b
However, event handlers for scroll and resize were still added when the component mounted:
gutenberg/packages/block-editor/src/components/typewriter/index.js
Lines 35 to 40 in d026d5b
These event handlers eventually try to reference the
ref
of thediv
that is only rendered in non-IE environments:gutenberg/packages/block-editor/src/components/typewriter/index.js
Line 100 in d026d5b
Thus, an error occurs.
With these changes, the entire component is bypassed in Internet Explorer, preventing any event handlers from being attached.
Testing Instructions:
Repeat steps to reproduce from Trac#49516.
Notably, I was able to reproduce this when scrolling in the editor in Internet Explorer.