-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry Pick PR's for WordPress 5.4 RC 2 #20743
Conversation
For the failing build, it might be necessary to cherry-pick this one as well: #20709 |
Thank you @aduth, that PR was included. |
packages/block-editor/src/components/default-block-appender/style.scss
Outdated
Show resolved
Hide resolved
6a06c55
to
b0a85e1
Compare
Should the changes of |
Hi @aduth, these changes applied a design to the button that looks good on g2 but not on trunk (as the button becomes different from all the other UI elements with a black background), so the changes on that file were not included. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As before, I'm most familiar with my own changes included here, but aside from the items I noted previously (which appear to be sorted), this looks in good shape 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested the PR and it all worked as expected. 👍
I did discuss some UI changes for the "W" icon in the upper left corner. Those are being implemented by @jorgefilipecosta.
bfc33bb
to
cdd5733
Compare
* adds raw excerpt to the LatestPosts block and respects manual excerpts * removed the reset to raw excerpt
cdd5733
to
ea15b1e
Compare
Thank you for this. I sense it was a tricky cherry-picking, so all the more thanks for taking care of it. |
Description
This PR cherry picks the following PR's into wp/trunk:
The following PR's had conflicts:
Improve the Back to WP button in Fullscreen Mode: Fixed by changing new variables to variables that exist in trunk. Changes in file packages/edit-post/src/components/header/fullscreen-mode-close/style.scss were tottally ignored as these changes seem g2 specific and did not matched the current design in trunk. cc: @youknowriad
Try, fix inserter being hidden: Fixed by changing new variables to variables that exist in trunk. cc: @jasmussen
Block Editor: Use full labels for directional block movers: The conflict was manually handled without any specific change. cc: @aduth
These PR's will be part of WordPress 5.4 RC 2.
How has this been tested?
I did some smoke tests and verified the branch, in fact, contained the expected fixes.