-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated Testing: Try composer non-interactive flag for Travis #21118
Conversation
Size Change: 0 B Total Size: 859 kB ℹ️ View Unchanged
|
Well, that didn't seem to help... |
Not sure if the environment variable wasn't being picked up for one reason or another. The result is a bit different when passing the flag (
It seems clearer by this that it's falling back to source as expected, but presumably because the Docker image doesn't have I'm not entirely sure, but since this setup process still uses the WordPress-based |
b6820a0
to
2e1fd1b
Compare
Thanks for starting to investigate this @aduth! I think passing It definitely looks like we're exceeding the GitHub API rate limit which, according to their docs, is a very paltry 60 requests per hour for unauthenticated requests. I tried creating a GitHub API token and having composer use it by setting the Instead I went with your suggestion to simply provide After merging WordPress/wpdev-docker-images#23 and waiting for the new images to be published, I re-ran the jobs on this PR and everything looks ✅ again. |
Thanks for the work in seeing this through, @noisysocks ! The outcome seems quite sensible to me, and regardless whether we should be expecting to be hitting a rate limit, having the additional redundancy in our build should prove valuable. |
This pull request seeks to attempt to resolve rate-limit errors which have become increasingly common in Travis builds lately:
It's unclear what is causing this to suddenly become an issue. There are related discussions which seem to imply that there should be no rate limit (example). The messaging in the error itself is also rather nonsensical ("0 calls/hr" limit, "wait until ? for the rate limit to reset"). It may in-fact be an issue of either Travis and/or GitHub.
The proposed changes are based upon the advice at composer/composer#1314 (comment) . Notably, this changes the behavior to fall back on a clone fallback if unable to fetch the composer dependencies (source). As implemented here, this can also be provided as an environment variable
COMPOSER_NO_INTERACTION
(composer/composer@83ea902). Generally speaking, it is sensible that we would configure Travis builds to run commands in a non-interactive mode when available.Testing Instructions:
If build history is any indication, the changes here can be assumed to be effective if the build merely passes.