Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks: Cover Text and Latest post shouldn't show left/right alignment options #2116

Merged
merged 1 commit into from
Aug 1, 2017

Conversation

youknowriad
Copy link
Contributor

When the "wideAlignments" is supported by the them, they show, "center", wide" and "full" alignment options and only the "center" option if the theme doesn't support the wide alignments

@youknowriad youknowriad self-assigned this Aug 1, 2017
@youknowriad youknowriad requested a review from mtias August 1, 2017 10:33
@codecov
Copy link

codecov bot commented Aug 1, 2017

Codecov Report

Merging #2116 into master will decrease coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2116      +/-   ##
==========================================
- Coverage   20.34%   20.33%   -0.01%     
==========================================
  Files         135      135              
  Lines        4237     4238       +1     
  Branches      722      722              
==========================================
  Hits          862      862              
- Misses       2843     2844       +1     
  Partials      532      532
Impacted Files Coverage Δ
blocks/library/latest-posts/index.js 10% <ø> (ø) ⬆️
blocks/library/cover-text/index.js 30% <ø> (ø) ⬆️
blocks/block-alignment-toolbar/index.js 37.5% <33.33%> (-5.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 733da48...60854d8. Read the comment docs.

@mtias
Copy link
Member

mtias commented Aug 1, 2017

Looks good. As discussed in slack, we'd want to avoid block implementors from being exposed to settings.wideImages at all, and let BlockAlignmentToolbar handle filtering out the options.

@youknowriad youknowriad merged commit 8ecd2ea into master Aug 1, 2017
@youknowriad youknowriad deleted the fix/controls-for-latest-posts-cover-text branch August 1, 2017 10:48
ceyhun pushed a commit that referenced this pull request Apr 22, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Align plus icon for the iOS Stepper control
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants