-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Enable edit button over Image blocks for Android #21165
[RNMobile] Enable edit button over Image blocks for Android #21165
Conversation
To enable "Edit" image option in Android as well
@@ -607,8 +606,7 @@ export class ImageEdit extends React.Component { | |||
! isUploadInProgress && | |||
! isUploadFailed && | |||
finalWidth && | |||
finalHeight && | |||
showMediaEditorButton && ( | |||
finalHeight && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're deleting a (
here, but I don't see that you're deleting the matching )
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. Don't know what I was thinking. 🤦♂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are working well! 👍
I've confirmed that the text alignment issue in the bottom sheet that you observed is not due to any changes in this PR, so I think we can merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with @mchowning !
Tested on Android and WPAndroid via wordpress-mobile/WordPress-Android#11557
Working like a charm! 🎉
Thank you so much for this PR @ashiagr !
Description
This PR removes
showMediaEditorButton
const
references to enable edit button over Image blocks for Android as well.The button was originally added as part of these PRs #19723, wordpress-mobile/gutenberg-mobile#1782 and was enabled only for iOS till now.
gutenberg-mobile
related PR: wordpress-mobile/gutenberg-mobile#2062WPAndroid
Issue: wordpress-mobile/WordPress-Android#11147(I don't have permissions on the main gutenberg repo, creating it in a fork-branch)
How has this been tested?
Creating it as a draft PR as it still needs to be tested.
Screenshots
To be included once tested.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: