Repair and refine embed block styles #21599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Code Quality
jasmussen
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
5 tasks
|
Size Change: -86 B (0%) Total Size: 824 kB
ℹ️ View Unchanged
|
jasmussen
force-pushed
the
fix/embed-block-styles-repair-refine
branch
from
f8c0d75
to
be5f8ba
Compare
jasmussen
force-pushed
the
fix/embed-block-styles-repair-refine
branch
2 times, most recently
from
621c8c4
to
e82f93e
Compare
|
Okay, rebased, refreshed, and tested again. The embed block with responsiveness works as it should, but this still makes for better specificity. It also fixes a few typos, and it fixes an issue where a floated embed can collapse into nothingness:
|
jasmussen
force-pushed
the
fix/embed-block-styles-repair-refine
branch
from
e82f93e
to
46b03bd
Compare
jasmussen
force-pushed
the
fix/embed-block-styles-repair-refine
branch
from
46b03bd
to
91aff35
Compare
|
I tried to test this PR on gutenberg.run, but trying to embed anything keeps failing there. Just looking at the code changes, though, they seem like an improvement to me. |
draganescu
approved these changes
May 13, 2020
|
THANK YOU! |
3 tasks
6 tasks
westonruter
reviewed
Oct 9, 2020
Comment on lines
-72
to
+77
| &.wp-embed-aspect-9-16 .wp-block-embed__wrapper::before { | ||
| padding-top: 177.78%; // 16 / 9 * 100 | ||
| } | ||
| .wp-embed-aspect-9-6 .wp-block-embed__wrapper::before { |
There was a problem hiding this comment.
@jasmussen This appears to have been typo, to provide 6 instead of 16. Fix provided in #25972.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #14648, so props to @m-e-h.
It's a good PR that aims to improve and refine the embed CSS to be less specific and work better. It also fixes some code quality and is overall a good PR.
Thank you @m-e-h for the PR!