Framework: Exit with non-zero status on docgen failed parse #21690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: #18840 (#18840 (comment)), #21467 (comment)
This pull request seeks to resolve an issue where child process failures occurring during
bin/api-docs/update-api-docs.js
do not result in a non-zero exit code. As seen at #21467 (comment), this can result in false positives where errors exist. The changes consist of a revert of the commit 4179376 from #18840.Testing Instructions:
Verify
update-api-docs.js
succeeds:Verify
update-api-docs.js
fails when parse error occurs: