Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove (optional) from value entry field in RangeControl docs #21695

Merged
merged 1 commit into from
May 14, 2020
Merged

Remove (optional) from value entry field in RangeControl docs #21695

merged 1 commit into from
May 14, 2020

Conversation

ajlende
Copy link
Contributor

@ajlende ajlende commented Apr 17, 2020

Description

Fixes #15931

For now, the recommended usage is to always have a number field coupled with the range control. Removal of the number field shouldn't be allowed.

The RangeControl code already enforces having the value entry field (by not providing an option to hide it), so only the documentation change was required to reflect that.

Types of changes

Documentation

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

cc @melchoyce

earnjam
earnjam approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@earnjam earnjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ajlende!

@earnjam earnjam merged commit c985009 into WordPress:master May 14, 2020
@github-actions github-actions bot added this to the Gutenberg 8.2 milestone May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earnjam earnjam earnjam approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gutenberg 8.2
Development

Successfully merging this pull request may close these issues.

RangeControl > Value entry field (optional):
2 participants
@ajlende @earnjam