Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types: Rename icons, primitives tsconfig to _tsconfig #21784

Merged
merged 1 commit into from
Apr 22, 2020

Commits on Apr 22, 2020

  1. Rename icons, primitives tsconfig to _tsconfig

    [#21613](#21613) "hid"
    TypeScript emitted type declarations for `@wordpress/element` when it
    was found to conflict with 3rd party type declarations on
    DefinitelyTyped.
    
    Disabling `@wordpress/element` cascaded to require disabling type
    checking for `@wordpress/icons` and `@wordpress/primitives`, two
    dependent packages.
    
    The lint-staged flow is slightly different from the full
    `build:package-types` script in that it attempts to do a minimal build
    in the interest of speed. This flow checks for the presence of a
    `tsconfig.json` file in the root of the package with changes and runs
    its package build.
    
    While removing the affected packages from the main tsconfig.json did
    remove them from the primary build, changes to primitives and icons
    packages will fail because they cannot find the `@wordpress/element`
    types as was intended in #21613.
    
    By renaming the package tsconfig.json files, they are excluded from the
    lint-staged typechecking as well.
    sirreal committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    535ca68 View commit details
    Browse the repository at this point in the history