-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Image center alignment behavior #21911
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfmohit
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
April 27, 2020 09:13
Size Change: +4 B (0%) Total Size: 835 kB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you wait a little bit before merging, I'd like to do some tests here. |
Absolutely, thank you guys ❤️ |
go ship it. Thanks for the fix. |
Done, thank you! ❤️ |
Thank you all for fixing this. Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tries to close #21885 which reports an error in the center-alignment behaviour in the image block, most likely introduced in #21822.
How has this been tested?
This PR has been tested by going through the following steps:
Screenshots
Types of changes
This PR just adds a
text-align: center
property to thefigure
element when the block'sdata-align
is set tocenter
.Checklist: