-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract block mover buttons so that they can be individually imported #22122
Conversation
Size Change: +198 B (0%) Total Size: 821 kB
ℹ️ View Unchanged
|
Do you think this still makes sense considering possible work in #21935 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good and works well so I'm approving. I'll leave the decision whether or not to merge this (as per the previous comment) up to @talldan .
@mtias I don't see much difference in #21935, the buttons in the movers would still need to have their focus managed individually. Having said that, there's some parallel work being done on the toolbar that has similar goals, but addresses this differently - #20008. (cc @diegohaz - it looks like our changes will conflict, this PR is to support mover buttons in the Block Navigator where they wouldn't be |
I've tested the PR again, and I can't see any issues. I'm going to move forward and merge this, it's a low risk change. |
Description
The Block mover buttons are exported as a single component. This PR allows the up and down buttons to be individually imported.
This change is required as part of #18014, which manages focus on the buttons using a roving tab index within the block navigator.
How has this been tested?
This is just a refactor, so no changes. Block movers should continue to look and work as they currently do.
Types of changes
Refactor
Checklist: