Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix "Cannot read property 'end' of undefined" on babel-plugin-makepot #21466 #22394

Merged
merged 3 commits into from
Jun 12, 2020

Conversation

miya0001
Copy link
Contributor

Description

Bug fix for #21466

How has this been tested?

  • I ran babel.js ./src -x '.tsx' -x '.ts' --config-file ./.babelrc.i18n and I saw *.pot was generated as expected.
  • My environment is Node v12.16.2.

Screenshots

Nothing

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@miya0001 miya0001 changed the title bug fix #21466 Bug fix "Cannot read property 'end' of undefined" on babel-plugin-makepot #21466 May 15, 2020
@torounit torounit added the [Tool] Babel plugin makepot /packages/babel-plugin-makepot label Jun 6, 2020
@torounit
Copy link
Member

torounit commented Jun 6, 2020

@miya0001

Is languages/gutenberg.pot generated by babel ?

@torounit torounit added the [Type] Bug An existing feature does not function as intended label Jun 6, 2020
@miya0001
Copy link
Contributor Author

miya0001 commented Jun 6, 2020

I haven't tried it with this project, but I saw it works as expected on my project with following command.

node_modules/@babel/cli/bin/babel.js ./src -x '.tsx' -x '.ts' --config-file ./.babelrc.i18n

.babelrc.i18n:

{
  "presets": ["@babel/preset-react", "@babel/preset-typescript"],
  "plugins": [["@wordpress/babel-plugin-makepot",{"output":"src/lang/lang.pot"}]]
}

@torounit
Copy link
Member

torounit commented Jun 8, 2020

@miya0001
It seems to me that the pot file should not be a commit.

@miya0001
Copy link
Contributor Author

miya0001 commented Jun 8, 2020

@torounit Removed. 😊

@torounit torounit self-assigned this Jun 10, 2020
@torounit torounit merged commit 8dca7e9 into WordPress:master Jun 12, 2020
@github-actions github-actions bot added this to the Gutenberg 8.4 milestone Jun 12, 2020
@miya0001 miya0001 deleted the bug-fix-for-babel-plugin-makepot branch June 12, 2020 02:54
This was referenced Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Tool] Babel plugin makepot /packages/babel-plugin-makepot [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants