-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit most used blocks to 6 elements #22521
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
A suggestion for improvement.
[Feature] Inserter
The main way to insert blocks using the + button in the editing interface
labels
May 21, 2020
youknowriad
requested review from
ajitbohra,
ellatrix,
jorgefilipecosta,
Soean and
talldan
as code owners
May 21, 2020 11:48
youknowriad
commented
May 21, 2020
Size Change: +1.58 kB (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
mtias
approved these changes
May 21, 2020
ZebulanStanphill
approved these changes
May 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise, it looks good to me. The failing end-to-end test involves the inserter, so if it's not just an intermittent/unrelated failure, the test may need to be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Inserter
The main way to insert blocks using the + button in the editing interface
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #21080
Nothing to add here :)