Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit most used blocks to 6 elements #22521

Merged
merged 2 commits into from
May 25, 2020
Merged

Conversation

youknowriad
Copy link
Contributor

@youknowriad youknowriad commented May 21, 2020

refs #21080

Nothing to add here :)

@youknowriad youknowriad added [Type] Enhancement A suggestion for improvement. [Feature] Inserter The main way to insert blocks using the + button in the editing interface labels May 21, 2020
@youknowriad youknowriad self-assigned this May 21, 2020
@github-actions
Copy link

github-actions bot commented May 21, 2020

Size Change: +1.58 kB (0%)

Total Size: 1.12 MB

Filename Size Change
build/a11y/index.js 1.14 kB +123 B (10%) ⚠️
build/api-fetch/index.js 3.4 kB +5 B (0%)
build/autop/index.js 2.83 kB +1 B
build/block-editor/index.js 105 kB +203 B (0%)
build/block-editor/style-rtl.css 10.9 kB +29 B (0%)
build/block-editor/style.css 10.9 kB +27 B (0%)
build/block-library/index.js 119 kB -377 B (0%)
build/block-library/style-rtl.css 7.48 kB -1 B
build/block-library/style.css 7.48 kB -1 B
build/block-serialization-default-parser/index.js 1.88 kB +2 B (0%)
build/compose/index.js 9.24 kB -1 B
build/core-data/index.js 11.4 kB +20 B (0%)
build/data-controls/index.js 1.29 kB +4 B (0%)
build/data/index.js 8.42 kB +2 B (0%)
build/edit-navigation/index.js 6.63 kB +6 B (0%)
build/edit-post/index.js 302 kB +16 B (0%)
build/edit-site/index.js 13.8 kB +906 B (6%) 🔍
build/edit-site/style-rtl.css 5.53 kB +219 B (3%)
build/edit-site/style.css 5.53 kB +221 B (3%)
build/edit-widgets/index.js 7.87 kB +139 B (1%)
build/edit-widgets/style-rtl.css 4.58 kB -15 B (0%)
build/edit-widgets/style.css 4.57 kB -15 B (0%)
build/editor/index.js 44.6 kB -3 B (0%)
build/element/index.js 4.65 kB +1 B
build/format-library/index.js 7.71 kB +71 B (0%)
build/hooks/index.js 2.13 kB +1 B
build/list-reusable-blocks/index.js 3.13 kB +1 B
build/media-utils/index.js 5.29 kB -1 B
build/nux/index.js 3.4 kB +1 B
build/rich-text/index.js 14.8 kB +1 B
build/server-side-render/index.js 2.67 kB -1 B
ℹ️ View Unchanged
Filename Size Change
build/annotations/index.js 3.62 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.93 kB 0 B
build/block-directory/style-rtl.css 790 B 0 B
build/block-directory/style.css 791 B 0 B
build/block-library/editor-rtl.css 7.17 kB 0 B
build/block-library/editor.css 7.17 kB 0 B
build/block-library/theme-rtl.css 684 B 0 B
build/block-library/theme.css 686 B 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/index.js 190 kB 0 B
build/components/style-rtl.css 17.1 kB 0 B
build/components/style.css 17.1 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 771 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.11 kB 0 B
build/edit-navigation/style-rtl.css 857 B 0 B
build/edit-navigation/style.css 856 B 0 B
build/edit-post/style-rtl.css 12.2 kB 0 B
build/edit-post/style.css 12.2 kB 0 B
build/editor/editor-styles-rtl.css 425 B 0 B
build/editor/editor-styles.css 428 B 0 B
build/editor/style-rtl.css 5.06 kB 0 B
build/editor/style.css 5.06 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keyboard-shortcuts/index.js 2.51 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.02 kB 0 B
build/viewport/index.js 1.84 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

Copy link
Member

@ZebulanStanphill ZebulanStanphill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise, it looks good to me. The failing end-to-end test involves the inserter, so if it's not just an intermittent/unrelated failure, the test may need to be updated.

@youknowriad youknowriad merged commit 861b3a0 into master May 25, 2020
@youknowriad youknowriad deleted the update/most-used-blocks branch May 25, 2020 10:17
@github-actions github-actions bot added this to the Gutenberg 8.2 milestone May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants