Fix submenu keyboard a11y in IE #22546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
tellthemachines
added
[a11y] Keyboard & Focus
[Focus] Accessibility (a11y)
|
Size Change: +26 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
adamziel
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #21136.
:focus-withindoesn't work on IE, so the Navigation block submenus are not keyboard accessible. This PR adds styles to.is-editingso that the submenu displays when its parent or its contents are focused.How has this been tested?
Tested with keyboard on IE: navigating between top-level and nested items is now possible.
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: