Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons for image tools, other, and update list icons #22593

Merged
merged 4 commits into from
Jun 2, 2020
Merged

Conversation

jasmussen
Copy link
Contributor

@jasmussen jasmussen commented May 25, 2020

This PR does three things:

Screenshot 2020-05-25 at 10 31 46

"Loop" is part of that screenshot, but the icon is already in the package

Screenshot 2020-05-25 at 10 48 01

@jasmussen jasmussen added [Type] Enhancement A suggestion for improvement. [Package] Icons /packages/icons labels May 25, 2020
@jasmussen jasmussen requested a review from gziolo May 25, 2020 08:49
@jasmussen jasmussen self-assigned this May 25, 2020
@github-actions
Copy link

github-actions bot commented May 25, 2020

Size Change: -7.83 kB (0%)

Total Size: 1.12 MB

Filename Size Change
build/annotations/index.js 3.62 kB +2 B (0%)
build/api-fetch/index.js 3.4 kB -1 B
build/block-directory/index.js 6.48 kB -452 B (6%)
build/block-directory/style-rtl.css 787 B -3 B (0%)
build/block-directory/style.css 787 B -4 B (0%)
build/block-editor/index.js 106 kB +325 B (0%)
build/block-editor/style-rtl.css 11.3 kB +432 B (3%)
build/block-editor/style.css 11.3 kB +435 B (3%)
build/block-library/editor-rtl.css 7.87 kB +704 B (8%) 🔍
build/block-library/editor.css 7.88 kB +706 B (8%) 🔍
build/block-library/index.js 125 kB +6.87 kB (5%) 🔍
build/block-library/style-rtl.css 7.68 kB +198 B (2%)
build/block-library/style.css 7.68 kB +199 B (2%)
build/block-serialization-default-parser/index.js 1.88 kB -1 B
build/blocks/index.js 48.1 kB -2 B (0%)
build/components/index.js 190 kB -5 B (0%)
build/components/style-rtl.css 19.5 kB +2.39 kB (12%) ⚠️
build/components/style.css 19.5 kB +2.4 kB (12%) ⚠️
build/compose/index.js 9.32 kB +36 B (0%)
build/core-data/index.js 11.4 kB +13 B (0%)
build/data-controls/index.js 1.29 kB -3 B (0%)
build/data/index.js 8.43 kB +4 B (0%)
build/date/index.js 5.47 kB -2 B (0%)
build/deprecated/index.js 772 B +1 B
build/edit-navigation/index.js 7.88 kB +1.25 kB (15%) ⚠️
build/edit-post/index.js 302 kB +48 B (0%)
build/edit-post/style-rtl.css 5.43 kB -6.79 kB (125%) 🏆
build/edit-post/style.css 5.43 kB -6.79 kB (125%) 🏆
build/edit-site/index.js 14.1 kB +276 B (1%)
build/edit-site/style-rtl.css 2.96 kB -2.57 kB (87%) 🏆
build/edit-site/style.css 2.96 kB -2.58 kB (87%) 🏆
build/edit-widgets/index.js 8.88 kB +1.01 kB (11%) ⚠️
build/edit-widgets/style-rtl.css 2.4 kB -2.17 kB (90%) 🏆
build/edit-widgets/style.css 2.4 kB -2.17 kB (90%) 🏆
build/editor/index.js 44.6 kB +4 B (0%)
build/editor/style-rtl.css 4.26 kB -793 B (18%) 👏
build/editor/style.css 4.27 kB -793 B (18%) 👏
build/element/index.js 4.64 kB -2 B (0%)
build/format-library/index.js 7.71 kB +4 B (0%)
build/hooks/index.js 2.13 kB +1 B
build/keyboard-shortcuts/index.js 2.51 kB +3 B (0%)
build/list-reusable-blocks/index.js 3.12 kB -3 B (0%)
build/notices/index.js 1.79 kB +1 B
build/nux/index.js 3.4 kB +3 B (0%)
build/plugins/index.js 2.56 kB -3 B (0%)
build/rich-text/index.js 14.8 kB -2 B (0%)
build/server-side-render/index.js 2.68 kB +1 B
build/viewport/index.js 1.84 kB -2 B (0%)
build/wordcount/index.js 1.17 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/autop/index.js 2.83 kB 0 B
build/blob/index.js 620 B 0 B
build/block-library/theme-rtl.css 684 B 0 B
build/block-library/theme.css 686 B 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.11 kB 0 B
build/edit-navigation/style-rtl.css 857 B 0 B
build/edit-navigation/style.css 856 B 0 B
build/editor/editor-styles-rtl.css 425 B 0 B
build/editor/editor-styles.css 428 B 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 5.29 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.02 kB 0 B
build/warning/index.js 1.14 kB 0 B

compressed-size-action

@jasmussen
Copy link
Contributor Author

Thank you Alex. I'm afk today, feel free to merge when the checks pass

@ajlende ajlende merged commit bf6ca54 into master Jun 2, 2020
@ajlende ajlende deleted the update/icons branch June 2, 2020 07:27
@github-actions github-actions bot added this to the Gutenberg 8.3 milestone Jun 2, 2020
@ajlende ajlende mentioned this pull request Jun 2, 2020
6 tasks
@ellatrix
Copy link
Member

ellatrix commented Jun 3, 2020

This PR is adding icons, but they are not used anywhere, or replacing other icons. Is this by intention?

@jasmussen
Copy link
Contributor Author

Yes, all of them have been requested on various PRs, most notably the image tools one, so they will be used. It's a chicken and egg thing. They should ideally be added on a per PR basis, but that often means the PR has to be postponed, so sometimes they get merged with the wrong icons and those are replaced later.

@jasmussen jasmussen mentioned this pull request Jun 3, 2020
@ellatrix
Copy link
Member

ellatrix commented Jun 3, 2020

Thanks @jasmussen! And thanks for updating the list icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Icons /packages/icons [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants