Docs: Extend details about features integration with theme.json
#22622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Developer Documentation
|
Size Change: +14 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
gziolo
force-pushed
the
update/docs-theme-json-features
branch
from
0becf23 to
01f3a5d
Compare
3 tasks
oandregal
reviewed
May 26, 2020
oandregal
reviewed
May 26, 2020
oandregal
reviewed
May 26, 2020
oandregal
reviewed
May 26, 2020
| @@ -158,66 +166,108 @@ The list of properties that are currently exposed via this method are: | |||
|
|
|||
| ### Features | |||
|
|
|||
| This is being implemented, so it's not currently available. | |||
| So far, this function is only enabled for the `global` section in `experimental-theme.json`. | |||
There was a problem hiding this comment.
What if we add an intro that sums up the general behavior (see). I'm thinking something along these lines:
Via the features key we allow controlling some editor and block features:
- The features within
globalwill override the default editor settings, which plugins still can modify by hooking into theblock_editor_settingsfilter in the server. - The features within each block content will override the default block settings, which plugins can still modify by hooking into the
blocks.registerBlockTypefilter in the client.
Block settings take precedence over global settings.
For example, if a feature is enabled for a block by default, although the theme disables it at the global level, the block will still have it enabled. If the theme wants to override a block's default, it has to target that particular block.
There was a problem hiding this comment.
Great idea, how do you like 816f31b?
gziolo
force-pushed
the
update/docs-theme-json-features
branch
2 times, most recently
from
e7ada48 to
816f31b
Compare
This was referenced May 27, 2020
gziolo
force-pushed
the
update/docs-theme-json-features
branch
2 times, most recently
from
d66c8c4 to
18f45d2
Compare
|
@nosolosw, I rebased this branch, do you think it's good to go now? |
oandregal
approved these changes
Jun 5, 2020
Co-authored-by: Andrés <nosolosw@users.noreply.github.com>
oandregal
force-pushed
the
update/docs-theme-json-features
branch
from
2fb751f to
9cfaabe
Compare
|
Thank you for rebasing, much appreciated 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for
and depends on#22291.This PR aims to document all the development happening in #22291 and accompanying PRs that try to expose blocks registration to the server.
The goal of these changes is to make it clear what's the order of applying block editor features depending on the place where they were defined when used with the following helper hook: