Add block transform to transform preformatted block into code block #22634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocean90
added
[Type] Enhancement
ocean90
requested review from
ajitbohra,
jorgefilipecosta,
nerrad,
ntwb,
Soean and
talldan
as code owners
6 tasks
|
Size Change: +15 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
ocean90
force-pushed
the
feature/block-transform-preformatted-code
branch
from
378a6ec
to
d9dffdc
Compare
youknowriad
reviewed
Jun 8, 2020
| { | ||
| type: 'block', | ||
| blocks: [ 'core/code' ], | ||
| transform: ( attributes ) => createBlock( 'core/code', attributes ), |
There was a problem hiding this comment.
I noticed that the "preformatted" content attribute has this property on it "__unstablePreserveWhiteSpace": true
I wonder if that means that we should sanitize the content when transforming cc @ellatrix
Also, do we want to support the opposite direction too?
There was a problem hiding this comment.
Also, do we want to support the opposite direction too?
Yes, but this is already implemented, see my gif in the Screenshot section.
There was a problem hiding this comment.
I think it's fine, because a textarea doesn't need anything special to preserve whitespace.
There was a problem hiding this comment.
And I believe we use characters for line breaks when __unstablePreserveWhiteSpace is enabled, so I don't think there's any HTML to strip. Worth noting that pre can contain HTML though. Can have bold, links etc.
ellatrix
approved these changes
Jun 8, 2020
This was referenced Jun 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This provides a block transform to transform Preformatted into Code.
How has this been tested?
Add a preformatted block, insert some content, convert to code block, ensure that the content is still there. Bonus: Convert back to preformatted and code is still there.
Screenshots
Types of changes
New feature
Checklist: