Fix image centering in gutenberg 8.2.0 #22693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
reviewed
May 28, 2020
| @@ -259,7 +259,7 @@ export function ImageEdit( { | |||
| } | |||
|
|
|||
| function updateAlignment( nextAlign ) { | |||
| const extraUpdatedAttributes = isWideAligned | |||
| const extraUpdatedAttributes = [ 'wide', 'full' ].includes( nextAlign ) | |||
There was a problem hiding this comment.
The wide alignment issue was a different regression introduced here 1063573#r39498180, I pushed a fix
youknowriad
referenced
this pull request
May 28, 2020
* Image block: use hooks * Use data hooks * Formatting * Fix e2e tests * Fix useSelect * Clean up * Fix select
youknowriad
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
youknowriad
added
the
[Type] Bug
ockham
approved these changes
May 28, 2020
youknowriad
force-pushed
the
fix/fix-image-center-alignment
branch
from
b8f8fd0 to
3571ce1
Compare
youknowriad
added a commit
that referenced
this pull request
May 28, 2020
Co-authored-by: Riad Benguella <benguella@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #22694
Description
Currently in 8.2.0, image centering is broken, I originally found it testing for wordpress.com and can confirm it also happens in gutenberg's docker testing environment
Before:
Automattic/wp-calypso#42637
How has this been tested?
Technical Details
It looks like the missing piece was that the
.components-resizable-box__containerelement no longer haddisplay: inline-block;set on it after this change https://github.com/WordPress/gutenberg/pull/22360/files#diff-d1d037caeeea85a91038b28fa70cd435L28Note
There is currently an issue with resizing the image and then setting it to "Wide width", if you do this, the image is not set to full screen like it should be